Project

General

Profile

Feature #10278

Bug #10250: Eliminate manual test suite

Feature #10277: Automatically test that Tails has booted correctly and without errors

Automatically test that services that we disable are not started

Added by anonym about 2 years ago. Updated about 1 month ago.

Status:
In Progress
Priority:
Normal
Assignee:
Category:
Test suite
Target version:
Start date:
09/26/2015
Due date:
% Done:

50%

QA Check:
Dev Needed
Feature Branch:
spriver:feature/10277
Type of work:
Code
Blueprint:
Easy:
Affected tool:

Description

I.e. verify #8313

History

#1 Updated by anonym about 2 years ago

  • Parent task set to #10277

#2 Updated by anonym about 2 years ago

  • Target version set to Tails_2.0

#3 Updated by kytv about 2 years ago

  • Tracker changed from Bug to Feature

#4 Updated by intrigeri about 2 years ago

Same comment + question as on #10279#note-3.

#5 Updated by anonym almost 2 years ago

  • Target version deleted (Tails_2.0)

#6 Updated by anonym almost 2 years ago

#7 Updated by intrigeri 11 months ago

#8 Updated by spriver 5 months ago

  • Assignee set to anonym
  • QA Check set to Ready for QA
  • Feature Branch set to spriver:feature/10277

#9 Updated by intrigeri 4 months ago

  • Target version set to Tails_3.2

#10 Updated by anonym 4 months ago

  • Blocks Feature #13239: Core work 2017Q3: Test suite maintenance added

#11 Updated by anonym 2 months ago

  • Status changed from Confirmed to In Progress
  • Assignee changed from anonym to spriver
  • % Done changed from 0 to 50
  • QA Check changed from Ready for QA to Dev Needed

Your test does exactly what is asked for in a clean way. Great! I was about to merge it but...

... I think we asked for too little. :) We also mask several units, and a masked unit is a type of disabled unit:

$ git grep -w mask config/chroot_local-hooks/52-update-rc.d
config/chroot_local-hooks/52-update-rc.d:systemctl mask systemd-networkd.service
config/chroot_local-hooks/52-update-rc.d:systemctl mask hwclock-save.service
config/chroot_local-hooks/52-update-rc.d:systemctl mask systemd-timesyncd.service
config/chroot_local-hooks/52-update-rc.d:systemctl mask apt-daily.timer
config/chroot_local-hooks/52-update-rc.d:systemctl mask pppd-dns.service

So I propose you also test that these units are masked. I suggest changing the step
Then /^the (\S+) systemd unit file is disabled$/ do |unit_name|

to
Then /^the (\S+) systemd unit file is (active|inactive) and (\S+)$/ do |unit_name, active_status, loaded_status|

and then use the stdout instead of return status of systemctl is-enabled and systemctl is-active.

Makes sense?

#12 Updated by intrigeri about 1 month ago

  • Target version changed from Tails_3.2 to Tails_3.3

#13 Updated by intrigeri 23 days ago

  • Blocks deleted (Feature #13239: Core work 2017Q3: Test suite maintenance)

Also available in: Atom PDF