Project

General

Profile

Bug #10718

Bug #10288: Fix newly identified issues to make our test suite more robust and faster

Lower waiting time for USB installation in the test suite

Added by intrigeri over 2 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Elevated
Assignee:
-
Category:
Test suite
Target version:
Start date:
12/06/2015
Due date:
% Done:

100%

QA Check:
Pass
Feature Branch:
Type of work:
Code
Blueprint:
Starter:
Affected tool:

Description

We currently wait one hour:

  @screen.wait('USBInstallationComplete.png', 60*60)

... which is just the same as our Jenkins inactivity timeout, so in practice when Tails Installer fails and displays an error message, instead of reporting that the job failed (which is the point of the exercise) we abort the job due to this timeout (which communicates waaaay less clearly to me, with my Tails Installer developer hat, that there's probably a bug I should fix, as opposed to "here's a transient failure caused by instabilities of our Jenkins setup"). My understanding is that this is what prevented the Tails Installer bug described on #10717 from being identified earlier, and I don't want to see that happen again.

IIRC this 1h timeout was relevant for running with nested virtualization on slightly old (ThinkPad X200) hardware. I don't think anyone does that anymore, and I would bet that on such hardware, lots of other bits of our test suite will time out anyway.

So I propose we decrease this to something like 30 minutes, i.e.:

  @screen.wait('USBInstallationComplete.png', 30*60)

If any of the watchers tells me to go ahead, and nobody raises concerns, I'll just do it on stable, devel and feature/jessie.

Associated revisions

Revision f10a95a5 (diff)
Added by intrigeri over 2 years ago

Lower waiting time for USB installation in the test suite.

So far we were waiting up to one hour, which is just the same as our
Jenkins inactivity timeout, so in practice when Tails Installer fails
and displays an error message, instead of reporting that the job failed
(which is the point of the exercise) we abort the job due to this
timeout (which communicates waaaay less clearly to me, with my Tails
Installer developer hat, that there's probably a bug I should fix, as
opposed to "here's a transient failure caused by instabilities of our
Jenkins setup"). My understanding is that this is what prevented the
Tails Installer bug described on #10717 from being identified earlier,
and I don't want to see that happen again.

IIRC this 1h timeout was relevant for running with nested virtualization
on slightly old (ThinkPad X200) hardware. I don't think anyone does that
anymore, and I would bet that on such hardware, lots of other bits of
our test suite will time out anyway.

Fix-committed: #10718

History

#1 Updated by intrigeri over 2 years ago

  • Tracker changed from Feature to Bug

#2 Updated by bertagaz over 2 years ago

intrigeri wrote:

... which is just the same as our Jenkins inactivity timeout, so in practice when Tails Installer fails and displays an error message, instead of reporting that the job failed (which is the point of the exercise) we abort the job due to this timeout (which communicates waaaay less clearly to me, with my Tails Installer developer hat, that there's probably a bug I should fix, as opposed to "here's a transient failure caused by instabilities of our Jenkins setup"). My understanding is that this is what prevented the Tails Installer bug described on #10717 from being identified earlier, and I don't want to see that happen again.

So I propose we decrease this to something like 30 minutes, i.e.:

[...]

Makes sense, I guess it's worth a try.

#3 Updated by intrigeri over 2 years ago

  • Type of work changed from Discuss to Code

I'll go ahead then.

#4 Updated by intrigeri over 2 years ago

  • Status changed from Confirmed to Fix committed
  • % Done changed from 0 to 100

#5 Updated by intrigeri over 2 years ago

  • Assignee deleted (intrigeri)

#6 Updated by anonym over 2 years ago

  • Status changed from Fix committed to Resolved
  • QA Check set to Pass

Also available in: Atom PDF