Project

General

Profile

Bug #11457

Bug #10288: Fix newly identified issues to make our test suite more robust and faster

"I close the Unsafe Browser" step is fragile

Added by intrigeri over 1 year ago. Updated about 1 month ago.

Status:
In Progress
Priority:
Normal
Assignee:
Category:
Test suite
Target version:
Start date:
05/22/2016
Due date:
% Done:

50%

QA Check:
Dev Needed
Feature Branch:
spriver:feature/11457-closing-unsafe-browser-is-fragile
Type of work:
Code
Blueprint:
Easy:
Affected tool:

Description

Video attached. I suspect that ctrl-q doesn't reach the right window, e.g. because it's emitted immediately after we close the notification area, and before GNOME Shell has had time to focus the browser's window. Perhaps we should explicitly focus it first?


Related issues

Blocks Tails - Feature #13240: Core work 2017Q4: Test suite maintenance Confirmed 06/29/2017

Associated revisions

Revision 3b6d1043 (diff)
Added by intrigeri over 1 year ago

Mark two tests as fragile.

refs: #11457

Revision d2276416 (diff)
Added by intrigeri over 1 year ago

Revert "Take into account that button ordering differs depending on the locale's text direction."

This reverts commit 6648c77d0df4ccfcf0f4a891e9ad41e426a676c4.

refs: #11457

History

#1 Updated by intrigeri over 1 year ago

  • Feature Branch set to test/11457-I-close-the-browser-is-fragile

#2 Updated by spriver 5 months ago

  • Subject changed from "I close the (?:Unsafe|I2P) Browser" step is fragile to "I close the Unsafe Browser" step is fragile

#3 Updated by spriver 5 months ago

  • Assignee set to anonym
  • QA Check set to Ready for QA
  • Feature Branch changed from test/11457-I-close-the-browser-is-fragile to spriver:feature/11457-closing-unsafe-browser-is-fragile

Done this by implementing clicking on the Unsafe Browser's icon on the start page.

#4 Updated by intrigeri 4 months ago

  • Target version set to Tails_3.2

#5 Updated by anonym 4 months ago

  • Blocks Feature #13239: Core work 2017Q3: Test suite maintenance added

#6 Updated by anonym 2 months ago

  • Assignee changed from anonym to spriver
  • % Done changed from 0 to 50
  • QA Check changed from Ready for QA to Dev Needed

From commit:023a16b0fbf2bff4a70285b9823d57dfea64be7c:

 When /^I close the Unsafe Browser$/ do
+  # Click on the picture on the start page to have the focus
+  # definitely in the Unsafe Browser before closing it
+  @screen.click('UnsafeBrowserHomepage.png')
   @screen.type("q", Sikuli::KeyModifier.CTRL)
 end

My only gripe here is that this step will only work if the Unsafe Browser's homepage is shown, and not if we have navigated to any other page. I suppose we currently only use this step in that situation, but it's good practice to avoid such surprising preconditions.

Normally how we deal with window detection and focusing is to have an image of the window title that we look for and click, respectively. It pains me to have us introduce more images, but I think that is the sensible solution here.

#7 Updated by BitingBird about 2 months ago

  • Status changed from Confirmed to In Progress

#8 Updated by intrigeri about 1 month ago

  • Target version changed from Tails_3.2 to Tails_3.3

#9 Updated by intrigeri 17 days ago

  • Blocks Feature #13240: Core work 2017Q4: Test suite maintenance added

#10 Updated by intrigeri 17 days ago

  • Blocks deleted (Feature #13239: Core work 2017Q3: Test suite maintenance)

Also available in: Atom PDF