Project

General

Profile

Bug #11521

Bug #10288: Fix newly identified issues to make our test suite more robust and faster

The check_tor_leaks hook is fragile

Added by intrigeri over 1 year ago. Updated about 1 month ago.

Status:
Confirmed
Priority:
Elevated
Assignee:
Category:
Test suite
Target version:
Start date:
06/10/2016
Due date:
% Done:

0%

QA Check:
Feature Branch:
Type of work:
Research
Blueprint:
Easy:
Affected tool:

Description

https://jenkins.tails.boum.org/job/test_Tails_ISO_feature-5650-rngd/8/ failed (pcap attached) with:

calling as root: systemctl is-system-running
call returned: [0, "running\n", ""]
    And Tor is ready                                                                           # features/step_definitions/common_steps.rb:373
calling as root: date --rfc-2822
call returned: [0, "Fri, 10 Jun 2016 18:18:47 +0000\n", ""]
    Then Tails clock is less than 5 minutes incorrect                                          # features/step_definitions/time_syncing.rb:40
      Time was 0.436531902 seconds off
      Unexpected connections were made:
        #<OpenStruct mac_saddr="50:54:00:f3:87:dc", mac_daddr="52:54:00:53:3c:df", protocol="tcp", saddr="10.2.1.92", daddr="10.2.1.1", sport=55150, dport=5024>.
      <false> is not true. (Test::Unit::AssertionFailedError)
      /usr/lib/ruby/vendor_ruby/test/unit/assertions.rb:55:in `block in assert_block'
      /usr/lib/ruby/vendor_ruby/test/unit/assertions.rb:1588:in `call'
      /usr/lib/ruby/vendor_ruby/test/unit/assertions.rb:1588:in `_wrap_assertion'
      /usr/lib/ruby/vendor_ruby/test/unit/assertions.rb:53:in `assert_block'
      /usr/lib/ruby/vendor_ruby/test/unit/assertions.rb:163:in `block in assert'
      /usr/lib/ruby/vendor_ruby/test/unit/assertions.rb:1593:in `call'
      /usr/lib/ruby/vendor_ruby/test/unit/assertions.rb:1593:in `_wrap_assertion'
      /usr/lib/ruby/vendor_ruby/test/unit/assertions.rb:130:in `assert'
      /var/lib/jenkins/workspace/test_Tails_ISO_feature-5650-rngd/features/support/helpers/firewall_helper.rb:68:in `assert_all_connections'
      /var/lib/jenkins/workspace/test_Tails_ISO_feature-5650-rngd/features/support/hooks.rb:274:in `After'

The pcap shows one initial packet (at time = 0) that's precisely the one that violates the assertion, and then a DCHP transaction 53s later, and then what looks like a Tor bootstrap with chutney 30s later. So, my theory is that the initial packet, that triggers the failure, is a leftover of the previous scenario, or something, and has nothing to do with the current scenario.

00_40_52_Clock_with_host_s_time_in_bridge_mode.pcap (58.9 KB) intrigeri, 06/10/2016 12:44 PM

00_41_12_Clock_with_host_s_time_in_bridge_mode.pcap (75.1 KB) bertagaz, 07/22/2016 03:35 AM

00_39_01_Clock_with_host_s_time_in_bridge_mode.pcap (64.9 KB) intrigeri, 07/29/2016 01:50 PM


Related issues

Blocks Tails - Feature #13240: Core work 2017Q4: Test suite maintenance Confirmed 06/29/2017

History

#1 Updated by intrigeri over 1 year ago

IIRC it's the first time I see this one, so no target version / deliverable for.

#2 Updated by intrigeri about 1 year ago

  • Priority changed from Normal to Elevated

It has happened 4 times in the last 50 days on Jenkins.

#3 Updated by bertagaz about 1 year ago

intrigeri wrote:

It has happened 4 times in the last 50 days on Jenkins.

That's mentioned on #11087#note-9. Attaching the pcap just in case.

#4 Updated by intrigeri about 1 year ago

Here's the pcap for another similar failure.

#5 Updated by anonym 8 months ago

  • Target version set to Tails_2.12

#6 Updated by anonym 6 months ago

  • Target version changed from Tails_2.12 to Tails_3.0~rc1

#7 Updated by intrigeri 5 months ago

  • Target version changed from Tails_3.0~rc1 to Tails_3.0

#8 Updated by intrigeri 5 months ago

  • Target version changed from Tails_3.0 to Tails_3.1

It would be nice to fix in 3.0 but that's not a blocker IMO => postponing.

#9 Updated by anonym 4 months ago

  • Blocks Feature #13239: Core work 2017Q3: Test suite maintenance added

#10 Updated by anonym 3 months ago

  • Target version changed from Tails_3.1 to Tails_3.2

#11 Updated by intrigeri about 1 month ago

  • Target version changed from Tails_3.2 to Tails_3.3

#12 Updated by intrigeri 17 days ago

  • Blocks Feature #13240: Core work 2017Q4: Test suite maintenance added

#13 Updated by intrigeri 17 days ago

  • Blocks deleted (Feature #13239: Core work 2017Q3: Test suite maintenance)

Also available in: Atom PDF