Project

General

Profile

Bug #11530

Feature #5663: Return to Icedove

Upgrade icedove to 45.1.0esr

Added by anonym over 2 years ago. Updated about 2 years ago.

Status:
Resolved
Priority:
Elevated
Assignee:
-
Category:
-
Target version:
Start date:
06/14/2016
Due date:
% Done:

100%

QA Check:
Pass
Feature Branch:
Type of work:
Code
Blueprint:
Starter:
Affected tool:
Email Client

Description

Currently version 1:45.1.0-1~deb8u1 is in Debian, which is higher than 38.8.0-1~deb8u1+tails3 from our custom APT suite. So the secure auto-configuration fixes are lost in current Tails builds.

We need to build new packages from 1:45.1.0-1~deb8u1 + our patches (which likely will need some refreshing).

History

#1 Updated by anonym over 2 years ago

  • Status changed from Confirmed to In Progress
  • Assignee changed from anonym to u
  • % Done changed from 0 to 60
  • QA Check set to Ready for QA

Given this crappy situation, I just built and uploaded 45.1.0-1~deb8u1+tails1. u, can you check that what I did in the tails/jessie branch in the icedove Git repo makes sense (as an after-the-fact review)?

This passed the full manual test suite, and solves #11486 and should improve #10933.

#2 Updated by u over 2 years ago

  • Assignee changed from u to anonym

Hi!

What you did looks fine.

One thing I noticed, which is different from the previous version:

 --- a/mailnews/base/prefs/content/accountcreation/fetchhttp.js
 +++ b/mailnews/base/prefs/content/accountcreation/fetchhttp.js
 @@ -96,6 +96,13 @@ FetchHTTP.prototype =
@@ -44,7 +44,7 @@ index 5f0cc70..436ac37 100644
 +
      for (var name in this._urlArgs)
      {
-       url += (!url.contains("?") ? "?" : "&") +
+       url += (!url.includes("?") ? "?" : "&") +


Is that expected?

In order to build normally, I had to modify debian/gbp.conf to use our tails/jessie branch, instead of Debian's jessie-security branch.

I'll push that to our main repo now.

#3 Updated by anonym over 2 years ago

  • Assignee changed from anonym to u
  • % Done changed from 60 to 80

u wrote:

Hi!

What you did looks fine.

Yay!

One thing I noticed, which is different from the previous version:
[...]
Is that expected?

It's a change from Mozilla upstream, one among many affecting the same files as our patches, so it is expected, see:

git log -p upstream/38.8.0..origin/tails/jessie -- mailnews/base/prefs/content/accountcreation/

In order to build normally, I had to modify debian/gbp.conf to use our tails/jessie branch, instead of Debian's jessie-security branch.

I've been cheating with gbp buildpackage --git-ignore-branch. :)

I'll push that to our main repo now.

Thanks for a proper solution!

Please close this ticket if you are happy with all this now.

#4 Updated by u over 2 years ago

  • Status changed from In Progress to Resolved
  • Assignee deleted (u)
  • % Done changed from 80 to 100
  • QA Check deleted (Ready for QA)

perfect. thanks!

#5 Updated by anonym over 2 years ago

  • Status changed from Resolved to Fix committed
  • QA Check set to Pass

#6 Updated by Kurtis about 2 years ago

Can you confirm that this fixes yfm6sdhnfbulplsw.onion/code/issues/10933 ?

#7 Updated by intrigeri about 2 years ago

  • Parent task set to #5663

#8 Updated by intrigeri about 2 years ago

  • Status changed from Fix committed to Resolved

Also available in: Atom PDF