Project

General

Profile

Feature #11753

Feature #11198: Port complex shell scripts into Python

Port complex shell scripts shipped in /usr/local to Python

Added by intrigeri over 1 year ago. Updated 28 days ago.

Status:
In Progress
Priority:
Elevated
Assignee:
Category:
-
Target version:
Start date:
08/27/2016
Due date:
% Done:

40%

QA Check:
Ready for QA
Feature Branch:
segfault:feature/11198
Type of work:
Code

History

#1 Updated by intrigeri over 1 year ago

  • Description updated (diff)

#2 Updated by intrigeri over 1 year ago

  • Blueprint set to https://tails.boum.org/blueprint/Port_shell_scripts_to_Python/

#3 Updated by intrigeri over 1 year ago

Note that we already had some preliminary work in feature/11198-python-scripting, but IIRC it was about converting some build time hook, while the pull request from goodcrypto is about scripts shipped to the user in /usr/local/{lib,*bin}.

#4 Updated by intrigeri over 1 year ago

  • Target version changed from Tails_2.6 to Tails_2.7

Sorry, we were not able to review this during the 2.6 cycle again. I'm postponing to 2.7 so that it's on top of anonym's review plate, even though this cannot go into 2.7 since it's a bugfix-only release.

#5 Updated by bertagaz about 1 year ago

  • Target version changed from Tails_2.7 to Tails_2.9.1

#6 Updated by anonym about 1 year ago

  • Target version changed from Tails_2.9.1 to Tails 2.10

#7 Updated by anonym 11 months ago

  • Target version changed from Tails 2.10 to Tails_2.11

#8 Updated by intrigeri 11 months ago

  • Priority changed from Normal to Elevated

#9 Updated by anonym 9 months ago

  • Target version changed from Tails_2.11 to Tails_2.12

#10 Updated by anonym 8 months ago

  • Target version changed from Tails_2.12 to Tails_3.0

#11 Updated by intrigeri 8 months ago

I don't think I want to merge this between 3.0~rc1 and 3.0, so I'll assume that "Target version = 3.0" means "I want to look into it between 3.0~rc1 and 3.0" so this can be merged in 3.2. So if we want (some of?) this in 3.0 final, please set target version to 3.0~rc1.

#12 Updated by anonym 8 months ago

intrigeri wrote:

"I want to look into it between 3.0~rc1 and 3.0" so this can be merged in 3.2.

This is what it means.

#13 Updated by intrigeri 7 months ago

  • Target version changed from Tails_3.0 to Tails_3.1

Our plan is to create one subtask per script, share the review work between anonym and I, and spread it over the next months, e.g. we would aim at tackling 1 script each for each Tails release cycle. anonym will create these tickets during the 3.1 cycle.

#14 Updated by intrigeri 6 months ago

#15 Updated by anonym 5 months ago

  • Target version changed from Tails_3.1 to Tails_3.2

#16 Updated by anonym 4 months ago

  • Assignee changed from anonym to segfault

Assigning to you per your interest. Let me know what you want me to do!

#17 Updated by BitingBird 4 months ago

  • Description updated (diff)

#18 Updated by segfault 3 months ago

  • Target version changed from Tails_3.2 to Tails_3.5

#19 Updated by intrigeri 2 months ago

#20 Updated by segfault about 1 month ago

  • Feature Branch changed from goodcrypto:feature/11198 to segfault:feature/11198

I started reviewing the portings done by goodcrypto. I cherry-picked some of the Python scripts, and updated them to include the modifications of the bash scripts since the initial portings. I also found and fixed some bugs and improved the code style a bit. The portings of goodcrypto are very close to the original bash scripts - which is convenient for reviewing, but sometimes results in unnecessary complex code, because some things could be done more elegantly in Python than in bash. This especially applies to the portings of the tailslib scripts, which I tend to reimplement at least partly (I already started with tailslib/tor.py).

Nevertheless, the porting was definitely a big effort, and I think it's shame that we didn't manage to use the results before (and give feedback to goodcrypto).

I pushed my preliminary results to the feature/11198 branch in my gitlab repository (https://gitlab.com/segfault_/tails).

#21 Updated by segfault about 1 month ago

  • % Done changed from 20 to 40

#22 Updated by intrigeri 28 days ago

Thanks a lot, segfault, for taking this over! :)

Also available in: Atom PDF