Project

General

Profile

Bug #11984

Error message when starting Totem: "Failed to get bookmarks list: library routine called out of sequence"

Added by elouann over 1 year ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Elevated
Assignee:
-
Category:
-
Target version:
Start date:
11/21/2016
Due date:
% Done:

100%

QA Check:
Pass
Feature Branch:
bugfix/11984-totem-apparmor
Type of work:
Code
Blueprint:
Starter:
Affected tool:

Description

Since Tails 2.7, an error appears whent starting Totem:

"Failed to get bookmarks list: library routine called out of sequence"


Related issues

Related to Tails - Bug #11578: Totem AppArmor profile allows opening OTR private key Resolved 07/19/2016
Duplicated by Tails - Bug #11978: totem player error on start after tails 2.7 upgrade Duplicate 11/21/2016

Associated revisions

Revision f825b001 (diff)
Added by intrigeri over 1 year ago

AppArmor Totem profile: add permissions needed to avoid warning on startup (refs: #11984).

This commit imports the current version of the changes I've submitted upstream
on
https://code.launchpad.net/~intrigeri/apparmor-profiles/+git/apparmor-profiles/+merge/310120

Revision 3d1878a1
Added by anonym over 1 year ago

Merge remote-tracking branch 'origin/bugfix/11984-totem-apparmor' into stable

Fix-committed: #11984

Revision 07e96492 (diff)
Added by anonym about 1 year ago

Test "Add local video..." in Totem.

Refs: #11984
Will-fix: #12019

History

#1 Updated by elouann over 1 year ago

  • Duplicated by Bug #11978: totem player error on start after tails 2.7 upgrade added

#2 Updated by intrigeri over 1 year ago

  • Assignee set to intrigeri
  • Priority changed from Normal to Elevated
  • Target version set to Tails_2.9.1
  • % Done changed from 100 to 0
  • Type of work changed from User interface design to Code

elouann: next time, please reassign such a regression to a member of the Foundations team. One should not rely on the fact we track all Redmine. Thanks :)

#3 Updated by elouann over 1 year ago

Ok I got it, thanks

#4 Updated by intrigeri over 1 year ago

  • Related to Bug #11578: Totem AppArmor profile allows opening OTR private key added

#5 Updated by intrigeri over 1 year ago

(Blame-free) post-mortem: I've messed things up when doing #11578, then entirely relied on our automated test suite (that doesn't expose this bug), and then I guess that bertagaz did exactly the same when he reviewed'n'merged my branch. Along the way from dev to release, apparently nobody ever started Totem without giving it an argument. I don't think we should rely on anyone doing that manually, given we have pretty good automated tests for Totem, and it makes sense to implicitly rely on them. So I wonder if we should perhaps add a test case about Totem starting from the apps menu without making a fuss (but I'm not sure if it's easy with Dogtail to check that Totem didn't display any error message); bertagaz, anonym: if you agree, please file the ticket.

Now I'm going to fix the actual bug.

#6 Updated by intrigeri over 1 year ago

  • Subject changed from Error message when starting Totem : "Failed to get bookmarks list: library routine called out of sequence" to Error message when starting Totem: "Failed to get bookmarks list: library routine called out of sequence"
  • Status changed from Confirmed to In Progress
  • Assignee changed from intrigeri to anonym
  • % Done changed from 0 to 50
  • QA Check set to Ready for QA

Tested locally (just starting Totem), works. No regression on Jenkins: https://jenkins.tails.boum.org/view/Tails_ISO/job/test_Tails_ISO_bugfix-11984-totem-apparmor/1/

#7 Updated by anonym over 1 year ago

  • Feature Branch set to bugfix/11984-totem-apparmor

#8 Updated by anonym over 1 year ago

  • Status changed from In Progress to Fix committed
  • Assignee deleted (anonym)
  • % Done changed from 50 to 100
  • QA Check changed from Ready for QA to Pass

Fix works => merged!

intrigeri wrote:

Along the way from dev to release, apparently nobody ever started Totem without giving it an argument.

I'm not surprised -- the Totem "main" window is truly mystifying, so I expect users to only start it through file associations in GNOME Files (or the command line). </Totem hate>

So I wonder if we should perhaps add a test case about Totem starting from the apps menu without making a fuss (but I'm not sure if it's easy with Dogtail to check that Totem didn't display any error message);

The error message will block any further action so if we make a test using Totem's UI to add a video and then watch it, we are good.

bertagaz, anonym: if you agree, please file the ticket.

#12019

#9 Updated by anonym over 1 year ago

  • Status changed from Fix committed to Resolved

Also available in: Atom PDF