Project

General

Profile

Feature #12503

Use rake to start the test suite in Jenkins

Added by bertagaz 6 months ago. Updated about 1 month ago.

Status:
In Progress
Priority:
Normal
Assignee:
Category:
Continuous Integration
Target version:
Start date:
05/03/2017
Due date:
% Done:

10%

QA Check:
Dev Needed
Feature Branch:
Type of work:
Sysadmin
Blueprint:
Easy:
Affected tool:

Description

While we worked on the vagrant build switch part of #5630 (#11972 and friends), the Rakefile got improved with some code that can be used to start the test suite through rake test.

There's been a pull request to use switch to this in Jenkins.


Related issues

Related to Tails - Feature #11972: Switch our Jenkins ISO build system to vagrant-libvirt Resolved 12/04/2016

History

#1 Updated by bertagaz 6 months ago

  • Related to Feature #11972: Switch our Jenkins ISO build system to vagrant-libvirt added

#2 Updated by intrigeri 6 months ago

  • Category changed from Infrastructure to Continuous Integration
  • Status changed from Confirmed to In Progress
  • % Done changed from 0 to 10

#3 Updated by bertagaz 5 months ago

  • Target version changed from Tails_3.1 to Tails_3.2

#4 Updated by bertagaz 2 months ago

  • Target version changed from Tails_3.2 to Tails_3.3

#5 Updated by intrigeri 2 months ago

  • Assignee changed from bertagaz to anonym
  • Target version changed from Tails_3.3 to Tails_3.2
  • QA Check changed from Ready for QA to Info Needed
  • Feature Branch deleted (wip/11972-use-vagrant-in-jenkins)

This has apparently been waiting to be reviewed since 3 months (granted, it's not high priority and I see no indication of what's the expected value of this change is). I would be happy to do at least an initial code review, but I cannot find the proposed branch. Where is it? Please reassign to me for QA once this is clarified.

And while you're at it: I'm concerned that we'll be maintaining two different ways to run our test suite, and developers are not using the same as our CI infra. Is the plan to switch to rake test for other use cases than Jenkins, e.g. regular developers? If yes, then wiki/src/contribute/release_process/test/usage.mdwn needs to be updated.

#6 Updated by bertagaz 2 months ago

intrigeri wrote:

This has apparently been waiting to be reviewed since 3 months (granted, it's not high priority and I see no indication of what's the expected value of this change is).

Yeah, I delayed it while trying to sort out my plate for 3.2.

I would be happy to do at least an initial code review, but I cannot find the proposed branch. Where is it? Please reassign to me for QA once this is clarified.

There's a feature/use-rake-test branch in the anonym/puppet-tails repo on git.tails.boum.org. The test rake task has been sniked into the merge of the branch for #11972.

And while you're at it: I'm concerned that we'll be maintaining two different ways to run our test suite, and developers are not using the same as our CI infra. Is the plan to switch to rake test for other use cases than Jenkins, e.g. regular developers? If yes, then wiki/src/contribute/release_process/test/usage.mdwn needs to be updated.

I think the plan was to use it in both cases.

#7 Updated by intrigeri 2 months ago

  • Assignee changed from anonym to intrigeri
  • QA Check changed from Info Needed to Ready for QA
  • Feature Branch set to anonym/puppet-tails:feature/use-rake-test

Thanks, adjusting metadata accordingly. I'll have a look but this should not block anonym from answering the other question :)

#8 Updated by intrigeri 2 months ago

  • Feature Branch deleted (anonym/puppet-tails:feature/use-rake-test)

The relevant commit (dee23d21093afc63c5126664426ae8a984c92729) was already merged on our master branch by mistake, and reverted in 6dc5891928297c1e3eb484e6e5af6c91964eaf5c. So this ticket is about reverting the revert.

#9 Updated by intrigeri 2 months ago

  • Assignee changed from intrigeri to anonym
  • QA Check changed from Ready for QA to Dev Needed

I had a look. So since a few months we have two independent implementations of the logic behind the args passed to Cucumber (i.e.: is release? only doc changes?). I'm not very happy with this situation, and now all our base branches support rake test, so let's clean this up. IMO next steps are:

  1. test rake test on a developer setup
  2. update our developer documentation to instruct using rake test
  3. drop the now obsolete code from wrap_test_suite on a topic branch, reassign to me for QA
  4. test the proposed Jenkins change either on a local clone of our Jenkins infra, or in production being ready to revert immediately if it breaks stuff

I can do the last (test/review/deploy) step, but I'd rather see those who initiated this transition handle the rest of it.

#10 Updated by intrigeri about 1 month ago

  • Target version changed from Tails_3.2 to Tails_3.4

(I'm not sure this is worth having a target version at all, but well. Your call.)

Also available in: Atom PDF