Project

General

Profile

Bug #12621

The 'Tor is ready' step fails when any systemd service fails

Added by anonym 7 months ago. Updated 5 days ago.

Status:
Confirmed
Priority:
Normal
Assignee:
Category:
Test suite
Target version:
-
Start date:
05/31/2017
Due date:
% Done:

0%

QA Check:
Feature Branch:
Type of work:
Discuss
Blueprint:
Starter:
Affected tool:

Description

Extracted from #12617:

intrigeri wrote:

anonym wrote:

[Any systemd service failing] breaks all automated tests using Tor, since the Tor is ready step runs systemctl is-system-running. The placement of that check in that step is my second issue: it doesn't belong. It should be moved into a dedicated step, run in a scenario about the health of the system. A failure would then in itself immediately signal something quite descriptive about the actual failure, instead of falsely signaling that something about little-t tor is utterly broken, blocking a huge part of the test suite.

Well, IMO it's good that we run systemctl is-system-running as often as we can, before testing other stuff, to identify issues as early as possible. IIRC we can't run it for offline scenarios since this check will fail if Tor hasn't started or bootstrapped. But I agree the current way this is implemented gives suboptimal feedback. Perhaps renaming the "Tor is ready" step to describe more accurately what we test in it would help.


Related issues

Blocks Tails - Feature #13240: Core work 2017Q4: Test suite maintenance Confirmed 06/29/2017

History

#1 Updated by anonym 7 months ago

  • Description updated (diff)

#2 Updated by anonym 6 months ago

  • Blocks Feature #13239: Core work 2017Q3: Test suite maintenance added

#3 Updated by anonym 5 months ago

  • Target version changed from Tails_3.1 to Tails_3.2

#7 Updated by intrigeri 3 months ago

  • Target version changed from Tails_3.2 to Tails_3.3

#8 Updated by intrigeri 2 months ago

  • Blocks Feature #13240: Core work 2017Q4: Test suite maintenance added

#9 Updated by intrigeri 2 months ago

  • Blocks deleted (Feature #13239: Core work 2017Q3: Test suite maintenance)

#10 Updated by intrigeri about 1 month ago

  • Target version changed from Tails_3.3 to Tails_3.5

#11 Updated by intrigeri 5 days ago

  • Target version deleted (Tails_3.5)

Also available in: Atom PDF