Bug #13437

Translations of notifications about clock and Tor are not applied

Added by xin about 1 month ago. Updated 7 days ago.

Status:ResolvedStart date:07/07/2017
Priority:NormalDue date:
Assignee:-% Done:

100%

Category:Internationalization
Target version:Tails_3.1
QA Check:Pass Blueprint:
Feature Branch:bugfix/13437-translations-not-applied, greeter:bugfix/13437-translations-not-applied Easy:
Type of work:Code Affected tool:Greeter

Description

Since 3.0, notifications about clock synchonization and Tor status are in English.

Tested with Spanish, French and German.


Related issues

Blocks Tails - Feature #13234: Core work 2017Q3: Foundations Team Confirmed 06/29/2017

Associated revisions

Revision f9648271
Added by intrigeri 25 days ago

Enable the bugfix-13437-translations-not-applied APT overlay (refs: #13437).

Revision d43a6328
Added by bertagaz 20 days ago

Merge remote-tracking branch 'origin/bugfix/13437-translations-not-applied' into stable

Fix-committed: #13437

History

#1 Updated by mercedes508 about 1 month ago

  • Status changed from New to Confirmed
  • Assignee set to sajolida

#2 Updated by sajolida about 1 month ago

  • Assignee changed from sajolida to bertagaz
  • Type of work changed from Research to Code

@bertagaz: This is a code bug, right? So assigning to you as the next RM.

#3 Updated by intrigeri about 1 month ago

  • Assignee changed from bertagaz to intrigeri
  • Target version set to Tails_3.1

@bertagaz: This is a code bug, right? So assigning to you as the next RM.

It's not part of the RM's job to take care of bugs.
Reassigning to me as the current Foundation Team on-call person.

#4 Updated by intrigeri 25 days ago

#5 Updated by intrigeri 25 days ago

  • Category set to Internationalization
  • Status changed from Confirmed to In Progress
  • % Done changed from 0 to 10
  • Affected tool set to Greeter

Regarding "Tor is ready": /etc/NetworkManager/dispatcher.d/60-tor-ready.sh expects it'll find $LANG in /etc/default/locale, which is not a valid assumption on Tails 3.0.1, which is a problem in itself. That's a bug in the Greeter's PostLogin.default, that calls localectl set-locale twice (once for $LANG, once for the formats settings). The second call overwrites the effect of the first one. I'll merge these two calls into a single one, so it should be a straightforward fix => adding to the foundations team's plate.

Regarding "Synchronizing the system's clock", we display this in two places:

  • /etc/NetworkManager/dispatcher.d/20-time.sh, in a rare case; this one has never been gettext'ized (there's a "XXX" in the code) so it's not a regression and I'll ignore it for now.
  • /usr/local/lib/tails-htp-notify-user, called by /etc/NetworkManager/dispatcher.d/20-time.sh too after doing export_gnome_env. I don't know why export_gnome_env doesn't pick up $LANG. It might be a consequence of the localectl -related bug described above, so I'll fix that one first and will see if it fixes this one.

#6 Updated by intrigeri 25 days ago

  • Feature Branch set to bugfix/13437-translations-not-applied, greeter:bugfix/13437-translations-not-applied

#7 Updated by intrigeri 25 days ago

intrigeri wrote:

  • /usr/local/lib/tails-htp-notify-user, called by /etc/NetworkManager/dispatcher.d/20-time.sh too after doing export_gnome_env. I don't know why export_gnome_env doesn't pick up $LANG.

Correction: it's not export_gnome_env's responsibility to do so. If $LANG was set in the NM environment, everything would work fine, so indeed I'll see if fixing the Greeter bug is enough.

#8 Updated by intrigeri 25 days ago

  • Assignee changed from intrigeri to bertagaz
  • % Done changed from 10 to 50
  • QA Check set to Ready for QA

The two regressions described above are fixed here (in French) by the topic branch.

#9 Updated by bertagaz 20 days ago

  • Status changed from In Progress to Fix committed
  • Assignee deleted (bertagaz)
  • % Done changed from 50 to 100
  • QA Check changed from Ready for QA to Pass

intrigeri wrote:

The two regressions described above are fixed here (in French) by the topic branch.

Seems they are, good catch! Merged the related branch, congrats.

#10 Updated by bertagaz 7 days ago

  • Status changed from Fix committed to Resolved

Also available in: Atom PDF