Project

General

Profile

Bug #14772

Test suite reports incomplete (and thus useless) info when systemctl is-system-running fails

Added by intrigeri 15 days ago. Updated 8 days ago.

Status:
In Progress
Priority:
Normal
Assignee:
-
Category:
Test suite
Target version:
Start date:
10/04/2017
Due date:
% Done:

100%

QA Check:
Pass
Feature Branch:
test/14772-log-more-useful-info-when-is-system-running-fails
Type of work:
Code
Blueprint:
Easy:
Affected tool:

Description

Listing the units is not enough: in most cases I've seen, is-system-running returns "starting" which means the job queue is not empty, and to debug that we need the list of jobs.

I'm aware anonym and I might not agree about whether we should run is-system-running in "Tor is ready", but I think we have another ticket to discuss that, and regardless where this code moves the proposed change will be useful so let's not block on orthogonal discussions :)


Related issues

Blocks Tails - Feature #13240: Core work 2017Q4: Test suite maintenance Confirmed 06/29/2017

Associated revisions

Revision cebaa5b3 (diff)
Added by intrigeri 15 days ago

Test suite: log the list of systemd jobs when systemctl is-system-running fails (refs: #14772).

Listing the units is not enough: in most cases I've seen, is-system-running
returns "starting" which means the job queue is not empty, and to debug that we
need the list of jobs.

Revision ede8f17a
Added by anonym 8 days ago

Merge remote-tracking branch 'origin/test/14772-log-more-useful-info-when-is-system-running-fails' into devel

Fix-committed: #14772

Revision dd985681 (diff)
Added by anonym 8 days ago

Test suite: allow more time for 'systemctl is-system-running' to succeed.

Hypothesis: #14772 is due to a race occurring after `step "the time
has synced"`, namely that the systemd units that will start when the
time is synced (and probably the same check is used for this as in
that step) haven't necessarily finished when we run `systemctl
is-system-running`. So let's just give it some more time.

Will-fix: #14772

History

#1 Updated by intrigeri 15 days ago

  • Status changed from Confirmed to In Progress
  • % Done changed from 0 to 10
  • QA Check set to Ready for QA
  • Feature Branch set to test/14772-log-more-useful-info-when-is-system-running-fails

#2 Updated by intrigeri 15 days ago

  • Assignee changed from intrigeri to anonym
  • % Done changed from 10 to 50

#3 Updated by intrigeri 15 days ago

  • Blocks Feature #13240: Core work 2017Q4: Test suite maintenance added

#4 Updated by anonym 8 days ago

  • Status changed from In Progress to Fix committed
  • Assignee deleted (anonym)
  • % Done changed from 50 to 100
  • QA Check changed from Ready for QA to Pass

Merged! As discussed on XMPP, I also committed dd985681bfc29f0fdf00a4ac762208b215579be7 on top (and now I realize its Will-fix: probably should've been a Refs:), which actually might also solve the root cause for this error. We'll see!

#5 Updated by anonym 8 days ago

  • Status changed from Fix committed to In Progress

Also available in: Atom PDF