Project

General

Profile

Bug #14793

Custom Desktop launchers are totally buggy

Added by intrigeri 11 days ago. Updated 7 days ago.

Status:
Fix committed
Priority:
High
Assignee:
-
Category:
-
Target version:
Start date:
10/06/2017
Due date:
% Done:

100%

QA Check:
Pass
Feature Branch:
bugfix/14783-trust-desktop-launchers
Type of work:
Code
Blueprint:
Easy:
Affected tool:

Description

They get the default icon instead of the configured one, e.g. tails-documentation.desktop specifies Icon=/usr/share/icons/gnome/48x48/categories/system-help.png, which is installed, but a text file -looking icon is displayed instead.

Their Name= is ignored i.e. the displayed label is e.g. tails-documentation.desktop.

Double-clicking on the icon opens an "Untrusted application launcher" dialog.

All these are caused by the fix for #14584, that will land in Stretch any time now, so it needs a fix based on our stable branch: if I click "Trust and launch" then the icon and name get fixed and I see no confirmation dialog next time I double-click the same launcher.

I think the fix is to add a trusted attribute in a gio/gvfs metadata, which is stored on the filesystem in ~/.local/share/gvfs-metadata.

I'm not surprised this component is bitrotting, see #13461#note-13 and #11717#note-13.


Related issues

Related to Tails - Bug #13461: The Desktop icons are sometimes not displayed since the upgrade to Stretch In Progress 07/12/2017
Related to Tails - Feature #11717: Drop launchers from the Desktop Rejected 08/25/2016
Related to Tails - Bug #14584: Backport security fix for Nautilus .desktop file RCE Rejected 09/01/2017

Associated revisions

Revision 4d7d7d62 (diff)
Added by intrigeri 10 days ago

Mark our custom Desktop launchers as trusted (refs: #14793, 14584).

History

#1 Updated by intrigeri 11 days ago

  • Related to Bug #13461: The Desktop icons are sometimes not displayed since the upgrade to Stretch added

#2 Updated by intrigeri 11 days ago

#3 Updated by intrigeri 11 days ago

  • Subject changed from Custom Desktop launchers get the default icon instead of the configured one on Buster to Custom Desktop launchers get the default icon instead of the configured one on Buster and their Name= is ignored

#4 Updated by intrigeri 11 days ago

  • Subject changed from Custom Desktop launchers get the default icon instead of the configured one on Buster and their Name= is ignored to Custom Desktop launchers are totally buggy on Buster
  • Description updated (diff)
  • Status changed from Confirmed to In Progress
  • % Done changed from 0 to 10
  • Feature Branch set to feature/buster

#5 Updated by intrigeri 11 days ago

  • Related to Bug #14584: Backport security fix for Nautilus .desktop file RCE added

#6 Updated by intrigeri 11 days ago

  • Priority changed from Normal to High

High prio as it totally breaks our test suite. We can downgrade priority if a short-term workaround is implemented there.

#7 Updated by intrigeri 11 days ago

I think we can use gio set to set the needed attribute.

#8 Updated by intrigeri 10 days ago

  • Status changed from In Progress to Resolved
  • % Done changed from 10 to 100

#9 Updated by intrigeri 7 days ago

  • Subject changed from Custom Desktop launchers are totally buggy on Buster to Custom Desktop launchers are totally buggy
  • Status changed from Resolved to In Progress
  • Assignee changed from intrigeri to anonym
  • Target version changed from Tails_4.0 to Tails_3.3
  • % Done changed from 100 to 50
  • QA Check set to Ready for QA
  • Feature Branch changed from feature/buster to bugfix/14783-trust-desktop-launchers
  • Type of work changed from Research to Code

#10 Updated by intrigeri 7 days ago

I don't remember if I've tested this branch on Stretch. And for sure I didn't do that after the Nautilus security update that makes us want this in stable was available. I'm confident it should work but if that's too sloppy for you, I would understand => reassign to me.

#11 Updated by anonym 7 days ago

  • Status changed from In Progress to Fix committed
  • Assignee deleted (anonym)
  • % Done changed from 50 to 100
  • QA Check changed from Ready for QA to Pass

intrigeri wrote:

I don't remember if I've tested this branch on Stretch. And for sure I didn't do that after the Nautilus security update that makes us want this in stable was available. I'm confident it should work but if that's too sloppy for you, I would understand => reassign to me.

Nope, it's fine. I built stable with this branch merged and it worked fine => merged!

Also available in: Atom PDF