Bug #3736

pull riseup branch to get new mysql handler options

Added by micah over 2 years ago. Updated 11 months ago.

Status:In ProgressStart date:01/05/2012
Priority:NormalDue date:
Assignee:micah% Done:

0%

Category:-
Target version:-
QA Check:Info Needed

Description

I added the mysql handler $nodata and $sqldumpoptions variables in our branch which are supported by the backupninja mysql handler, please review and merge

History

#1 Updated by micah about 2 years ago

  • Status changed from New to In Progress
  • Assignee set to rhatto
  • QA Check set to Ready for QA

Rhatto, as one of the project leads on the backupninja puppet shared module project, can you review this code and merge it if its ok? I would do it, but I wrote it myself. The other person who is project "lead" on this module is jamie, and I just assigned another review to him, so this one is for you!

#2 Updated by rhatto 11 months ago

  • Assignee changed from rhatto to micah
  • QA Check changed from Ready for QA to Info Needed

micah wrote:

Rhatto, as one of the project leads on the backupninja puppet shared module project, can you review this code and merge it if its ok? I would do it, but I wrote it myself. The other person who is project "lead" on this module is jamie, and I just assigned another review to him, so this one is for you!

Thanks for that :)

I reviewed your changes and I'm ready to merge. In fact, in my own branch I have implemented $sqldumpoptions with defaults to '--lock-tables --complete-insert --add-drop-table --quick --quote-names' instead of "false". Which values you think are better to leave as default?

Also available in: Atom PDF