Project

General

Profile

Feature #6038

Feature #14568: Additional Software Packages

Additional software: fix installation of packages requiring manual confirmation

Added by Tails over 4 years ago. Updated about 9 hours ago.

Status:
Fix committed
Priority:
Normal
Assignee:
-
Category:
Persistence
Target version:
Start date:
Due date:
12/15/2017
% Done:

100%

QA Check:
Pass
Feature Branch:
feature/6038-debconf-priority
Type of work:
Code
Blueprint:
Starter:
No
Affected tool:
Additional Software Packages

Description

Currently this feature fails to install packages that require manual confirmation. For example sun-java6-jdk. Setting debconf priority to critical should help.

Associated revisions

Revision 7d47cbaf (diff)
Added by alant 10 days ago

additional software: use debconf priority critical

Will-fix: #6038

Revision fcc7a9c2 (diff)
Added by alant about 10 hours ago

additional software: use debconf priority critical

Will-fix: #6038

History

#1 Updated by Tails over 4 years ago

  • Parent task set to #5551

#2 Updated by intrigeri about 4 years ago

  • Category set to Persistence
  • Starter set to No

#3 Updated by BitingBird over 3 years ago

  • Subject changed from additional software: fix installation of packages requiring manual confirmation to Additional software: fix installation of packages requiring manual confirmation

#4 Updated by intrigeri over 3 years ago

  • Type of work changed from Research to Code

Setting debconf priority to critical should be just enough: iirc, it's a violation of the Debian Policy to require interactive input in other ways that debconf on package installation.

#5 Updated by u 4 months ago

  • Assignee set to alant

I strongly suppose that this will have to be done during or even before the work on a GUI for additional software. Assigning to alan.

#6 Updated by BitingBird 4 months ago

  • Target version set to 2018

#7 Updated by u 3 months ago

  • Parent task changed from #5551 to #14568

#8 Updated by u 3 months ago

  • Parent task changed from #14568 to #5551

#9 Updated by u 3 months ago

  • Target version changed from 2018 to Tails_3.5
  • Affected tool set to Additional Software Packages

#10 Updated by intrigeri 3 months ago

If I'm not mistaken, this is not formally part of SponsorW_2017. I propose we move it our of that view for now, but keep that in mind for #14592: I doubt many users will install such packages so perhaps we will prefer to focus on polishing & bugfixing that has a greater impact, even though the impact of this bug is pretty bad when it happens.

What do you think?

#11 Updated by sajolida 3 months ago

I agree.

Now, how complicated would it be to detect such packages as part of SponsorW_2017 and display a message saying "Sorry, Additional Software doesn't work with this package because it requires manual confirmation.". So we're not silently failing.

#12 Updated by intrigeri 3 months ago

Now, how complicated would it be to detect such packages as part of SponsorW_2017 and display a message saying "Sorry, Additional Software doesn't work with this package because it requires manual confirmation.". So we're not silently failing.

Probably harder than fixing the problem (which should be easy in itself, so if we have extra time, I'd actually love if we could fix it :)

#13 Updated by u 3 months ago

  • Parent task changed from #5551 to #14568

#14 Updated by u 3 months ago

I'm keeping this ticket in the view for now, but not as a deliverable for Sponsor_W.

#15 Updated by intrigeri 3 months ago

Deliverable for changed from SponsorW_2017 to Tails_3.7

I'm keeping this ticket in the view for now, but not as a deliverable for Sponsor_W.

Setting "Deliverable for" to a Tails version is new and has no well-defined semantics, so I wonder: did you mean to set "Target version: Tails_3.7" instead?

#16 Updated by u 3 months ago

Oops, no, I wanted to unset the deliverable.

#17 Updated by u 2 months ago

  • Target version changed from Tails_3.5 to Tails_3.6

#18 Updated by u 2 months ago

  • Target version changed from Tails_3.6 to Tails_3.5

#19 Updated by alant 2 months ago

  • Due date set to 12/15/2017

#20 Updated by alant 10 days ago

  • Assignee changed from alant to u
  • QA Check set to Info Needed
  • Feature Branch set to feature/6038-debconf-priority

I don't understand what would anything else then -y:

-y, --yes, --assume-yes

Automatic yes to prompts; assume "yes" as answer to all prompts and run non-interactively. If an undesirable situation, such as changing a held package, trying to install a unauthenticated package or removing an essential package occurs then apt-get will abort. Configuration Item: APT::Get::Assume-Yes.

In case it is needed the branch feature/6038-debconf-priority should fix debconf priority.

However I failed to find a way to test this: sun-java6-jdk isn't available anymore, and I can't find another package that fails. Please provide another example if you have one.

It's unclear to me if solving this issue is a requirement before working on additional software packages. I engaged to do so, but the above comments seems to disagree. In case it's not that easy, what sould we do?

#21 Updated by alant 10 days ago

  • Status changed from Confirmed to In Progress

#22 Updated by intrigeri 10 days ago

  • Assignee changed from u to intrigeri

I don't understand what would anything else then -y:

[...]

In case it is needed the branch feature/6038-debconf-priority should fix debconf priority.

However I failed to find a way to test this: sun-java6-jdk isn't available anymore,
and I can't find another package that fails. Please provide another example if you
have one.

I'll try to.

It's unclear to me if solving this issue is a requirement before working on additional software packages. I engaged to do so, but the above comments seems to disagree. In case it's not that easy, what sould we do?

I'll send this back to u if, and only if, there's a need to.

#23 Updated by intrigeri 9 days ago

  • Assignee changed from intrigeri to alant
  • % Done changed from 0 to 10
  • QA Check deleted (Info Needed)

alant wrote:

I don't understand what would anything else then -y:

I think this ticket is about input requested via debconf. I don't think this APT option affects debconf's behaviour so it solves a different problem.

In case it is needed the branch feature/6038-debconf-priority should fix debconf priority.

Great. At first glance it should fix the problem for debconf questions with priority < critical. It won't fix it for questions with priority >= critical but I think there's nothing we can do non-interactively about those.

However I failed to find a way to test this: sun-java6-jdk isn't available anymore, and I can't find another package that fails. Please provide another example if you have one.

Any package that ships a debconf question with priority at least as high as the value of our current debconf/priority setting (== high?) should expose the problem. One way to find them is to look e.g. for db_input high on codesearch: https://codesearch.debian.net/search?q=db_input+high&perpkg=1.

Once you've tested your change, please reassign to me for QA :)

It's unclear to me if solving this issue is a requirement before working on additional software packages. I engaged to do so, but the above comments seems to disagree.

This ticket is not formally on the detailed list of things we've promised so from a purely bureaucratic point of view, one can surely argue it's not a deliverable. But if you look at things at a user-centric level, this project is about making ASP Just Work™ for non-technical users, so arguably anything that causes UX annoyances is potentially in scope. Now, of course we can't fix all the bugs in the world, so it's our job to prioritize what is worth fixing depending on the cost/benefit. In this case it seems that a one-liner trivial change makes the situation much better, so it seems to me it's worth it even though it probably does not affect many packages that users would want to add to their list of ASP (now, once this feature is easier to use and vastly more people use it, who knows what'll happen :).

Still, that's a good question:

In case it's not that easy, what sould we do?

Re-prioritize => best effort or simply give up for now.

#24 Updated by alant 1 day ago

The proposed fix allows to install the sslh (asking a debconf question of priority high), which fails without it.

#25 Updated by intrigeri about 11 hours ago

Code review passes, I'll now test.

#26 Updated by intrigeri about 10 hours ago

  • Status changed from In Progress to Fix committed
  • Assignee deleted (alant)
  • % Done changed from 10 to 100
  • QA Check set to Pass

Works, merged!

#27 Updated by alant about 10 hours ago

  • Status changed from Fix committed to In Progress

#28 Updated by intrigeri about 9 hours ago

  • Status changed from In Progress to Fix committed

Also available in: Atom PDF