Project

General

Profile

Feature #6154

Feature #5663: Return to Icedove

Feature #6148: Torbirdy in Debian

Secure the Icedove autoconfig wizard

Added by Tails over 4 years ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Elevated
Assignee:
-
Category:
-
Target version:
Start date:
10/16/2013
Due date:
% Done:

100%

QA Check:
Pass
Feature Branch:
feature/6154-secure-autoconfig-in-icedove
Type of work:
Code
Blueprint:
Starter:
No
Affected tool:
Email Client

Subtasks

Feature #6157: Fix re-test in secure Icedove autoconfig wizardResolved

Feature #6158: Fix secure Icedove autoconfig wizard in TailsResolved

Feature #6367: Rebase our patches on top of Icedove 24Resolved

Feature #6368: Test our rebased patches on Icedove 38Resolved

Feature #6369: Build Debian packages of Icedove 38 with our patches / create proper branch situationResolved

Feature #7064: Update our plans for securing Icedove's autoconfig wizard wrt. recent developmentsResolved

Feature #6149: Wait for Torbirdy patches design documentationResolved

Feature #7746: Rebase our patches on top of Icedove 38Resolved

Feature #9492: Adapt the patchset to work on current IcedoveDuplicate

Feature #11204: Make sure we get all the benefits from TorBirdy's own account wizardResolved

Feature #11215: Update Icedove design documentation wrt. the autoconfig wizardResolved

Feature #11503: Update our doc to the Icedove autoconfig wizardResolved


Related issues

Related to Tails - Bug #11486: Icedove autoconfig wizard gets stalled on some domains Resolved 05/24/2016
Blocks Tails - Feature #10464: Disable remote email account creation in Icedove Resolved 11/01/2015
Blocks Tails - Bug #10906: Enigmail is configured to use a cleartext hkp:// keyserver Resolved 01/12/2016

Associated revisions

Revision 898564ba
Added by intrigeri over 1 year ago

Merge branch 'feature/6154-secure-autoconfig-in-icedove' into devel

fix-committed: #6154, #10906, #10905, #10574, #10464

History

#1 Updated by Tails over 4 years ago

  • Parent task set to #5663

#2 Updated by intrigeri over 4 years ago

  • Type of work set to Code

Type of work: Code

#3 Updated by intrigeri almost 4 years ago

  • Subject changed from secure Icedove autoconfig wizard to Secure the Icedove autoconfig wizard
  • Starter set to No

#4 Updated by intrigeri over 3 years ago

  • Category set to 212

#6 Updated by intrigeri over 2 years ago

  • Assignee set to u
  • Target version set to 246

#7 Updated by kytv over 2 years ago

  • Blocks Feature #10009: Decide whether to disable remote email account creation in Icedove added

#8 Updated by sajolida about 2 years ago

  • Related to Feature #10464: Disable remote email account creation in Icedove added

#9 Updated by sajolida about 2 years ago

  • Related to deleted (Feature #10464: Disable remote email account creation in Icedove)

#10 Updated by sajolida about 2 years ago

  • Blocks Feature #10464: Disable remote email account creation in Icedove added

#11 Updated by sajolida about 2 years ago

  • Blocks deleted (Feature #10009: Decide whether to disable remote email account creation in Icedove)

#12 Updated by sajolida about 2 years ago

  • Target version changed from 246 to Tails_2.0

#13 Updated by u about 2 years ago

  • Target version changed from Tails_2.0 to Tails_2.2

#14 Updated by anonym almost 2 years ago

  • Feature Branch set to feature/6154-secure-autoconfig-in-icedove

#15 Updated by u almost 2 years ago

  • Target version changed from Tails_2.2 to Tails_2.3

#16 Updated by anonym over 1 year ago

  • Target version changed from Tails_2.3 to Tails_2.4

#17 Updated by intrigeri over 1 year ago

  • Blocks Bug #10906: Enigmail is configured to use a cleartext hkp:// keyserver added

#18 Updated by anonym over 1 year ago

  • Blocks deleted (Feature #6156: Upstream secure Icedove autoconfig wizard)

#19 Updated by anonym over 1 year ago

  • Status changed from Confirmed to In Progress
  • Assignee changed from u to intrigeri
  • QA Check set to Ready for QA

#20 Updated by intrigeri over 1 year ago

Code review (in tails.git) passes. I've not looked at the Icedove patches though.

I've pushed a few minor improvements on top:

And two more comments:

  • config/chroot_local-patches/torbirdy-0001-secure-autoconfig-compat.diff says "This patch will be upstreamed in TorBirdy" but I've found no ticket about it ⇒ created #11484
  • In config/chroot_local-patches/torbirdy-0002-secure-autoconfig-POP-defaults.diff the monkeypatched functions have no explicit return value. Shall we perhaps return whatever the wrapped function has returned? Ignore me if this doesn't make sense, I don't need to understand all this, I just want to ensure that you've thought about how this can potentially break stuff in the future (in case the return value starts mattering some day).

Now I'm going to test the thing and check that it behaves as planned (I'll also check the subtasks that were already marked as resolved, to make sure I'm not missing anything, if I have time).

#21 Updated by anonym over 1 year ago

intrigeri wrote:

Code review (in tails.git) passes. I've not looked at the Icedove patches though.

Yay!

I've pushed a few minor improvements on top:

And two more comments:

  • config/chroot_local-patches/torbirdy-0001-secure-autoconfig-compat.diff says "This patch will be upstreamed in TorBirdy" but I've found no ticket about it ⇒ created #11484

This is the old patch, that already has been upstreamed => rejecting.

  • In config/chroot_local-patches/torbirdy-0002-secure-autoconfig-POP-defaults.diff

This is the new patch that is gonna be upstreamed, and we already have a PR so I think we don't need to track it in our Redmine.

the monkeypatched functions have no explicit return value. Shall we perhaps return whatever the wrapped function has returned? Ignore me if this doesn't make sense, I don't need to understand all this, I just want to ensure that you've thought about how this can potentially break stuff in the future (in case the return value starts mattering some day).

I won't bother with this -- the nature of these two methods is to show/hide/fill in info, e.g. side-effects. Ok?

#22 Updated by intrigeri over 1 year ago

  • Related to Bug #11486: Icedove autoconfig wizard gets stalled on some domains added

#23 Updated by intrigeri over 1 year ago

Works fine, except #11486.

#24 Updated by intrigeri over 1 year ago

  • In config/chroot_local-patches/torbirdy-0002-secure-autoconfig-POP-defaults.diff

This is the new patch that is gonna be upstreamed, and we already have a PR so I think we don't need to track it in our Redmine.

Fair enough. We'll revisit if this takes too much time and hits us later (unlikely :)

I won't bother with this -- the nature of these two methods is to show/hide/fill in info, e.g. side-effects. Ok?

OK.

#26 Updated by intrigeri over 1 year ago

  • Status changed from In Progress to Fix committed
  • Assignee deleted (intrigeri)
  • QA Check changed from Ready for QA to Pass

Merged, congrats!

#27 Updated by anonym over 1 year ago

  • Status changed from Fix committed to Resolved

Also available in: Atom PDF